docs: add design for enforcing host network. #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan47
suggested changes
Nov 11, 2024
obnoxxx
changed the title
obnoxxx
force-pushed
the
design-enforce_host_net
branch
from
89df060 to
2e71b04
Compare
Madhu-1
requested changes
Nov 11, 2024
obnoxxx
force-pushed
the
design-enforce_host_net
branch
2 times, most recently
from
324a6aa to
7e68bc4
Compare
obnoxxx
force-pushed
the
design-enforce_host_net
branch
4 times, most recently
from
7fa11c7 to
e141e75
Compare
nb-ohad
requested changes
Nov 11, 2024
obnoxxx
force-pushed
the
design-enforce_host_net
branch
from
e141e75 to
690a2a7
Compare
travisn
reviewed
Nov 11, 2024
Madhu-1
reviewed
Nov 12, 2024
obnoxxx
force-pushed
the
design-enforce_host_net
branch
from
477f5d5 to
440d18f
Compare
|
@Madhu-1 wrote:
done. |
obnoxxx
force-pushed
the
design-enforce_host_net
branch
from
440d18f to
14d64b3
Compare
obnoxxx
force-pushed
the
design-enforce_host_net
branch
from
5662954 to
9bfab5c
Compare
Madhu-1
reviewed
Nov 13, 2024
obnoxxx
force-pushed
the
design-enforce_host_net
branch
2 times, most recently
from
f5b7a9a to
16b476e
Compare
Madhu-1
reviewed
Nov 13, 2024
|
@nb-ohad PTAL as you have requested changes |
obnoxxx
force-pushed
the
design-enforce_host_net
branch
5 times, most recently
from
c82931a to
2da9b5f
Compare
obnoxxx
force-pushed
the
design-enforce_host_net
branch
from
fe838b2 to
c111ce0
Compare
Madhu-1
reviewed
Nov 13, 2024
obnoxxx
force-pushed
the
design-enforce_host_net
branch
from
c111ce0 to
b3ceca6
Compare
Signed-off-by: Michael Adam <obnox@samba.org>
Madhu-1
approved these changes
Nov 13, 2024
obnoxxx
force-pushed
the
design-enforce_host_net
branch
from
1bf399d to
fa2df3e
Compare
nb-ohad
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR adds a design document for a way to enable the use of host networking on Ceph-CSI controller plugin pods.
Is there anything that requires special attention
Is the change backward compatible?
yes as it is only adding a document.
Are there concerns around backward compatibility?
none
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
It is a first step toward a solution for issue #157
but not an implementation and hence not a complete solution yet.
Future concerns
none.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.