Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update go version to 1.23.0 #191

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Jan 2, 2025

Describe what this PR does

updating the go version to 1.23.0 as its required for kubernetes as well.

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

  • Kubernetes links that explain why the change is required
  • Ceph-CSI spec related changes/catch-up that necessitates this patch
  • golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide
    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes

    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

updating the go version to 1.23.0
as its required for kubernetes
as well.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 Madhu-1 requested a review from nb-ohad January 2, 2025 07:52
using the latest version of golangci-lint
built for 1.23

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
in latest version of golangci-lint
we need to check all the errors, This
commit fixes the same in test files.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updating the build image from 1.22 to
1.23 in the dockerfile.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant