Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip config folder from running codespell ci #22

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

subhamkrai
Copy link
Contributor

@subhamkrai subhamkrai commented Jun 25, 2024

Describe what this PR does

config folder are auto generated and there is no need to
run codespell on auto generated files.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide
    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes

    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subhamkrai please update the PR description and commit about why this change is requried.

config folder are auto generated and there is no need to
run codespell on auto generated files.

Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai subhamkrai force-pushed the skip-config-codespell branch from c0d32b0 to f949b51 Compare June 25, 2024 12:16
@subhamkrai subhamkrai requested a review from Madhu-1 June 25, 2024 12:17
@subhamkrai
Copy link
Contributor Author

@subhamkrai please update the PR description and commit about why this change is requried.

done

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jun 25, 2024

config folder are auto generated and there is no need to run codespell on auto generated files.

Is this true, i know that we also edit these files manually isn't it true (i think we update the sample with an example yaml)?

@subhamkrai
Copy link
Contributor Author

config folder are auto generated and there is no need to run codespell on auto generated files.

Is this true, i know that we also edit these files manually isn't it true (i think we update the sample with an example yaml)?

I got the knowledge from @nb-ohad

@Madhu-1 Madhu-1 merged commit 79e1e09 into ceph:main Jun 25, 2024
4 checks passed
parth-gr pushed a commit to parth-gr/ceph-csi-operator that referenced this pull request Aug 26, 2024
Bug 2305274:[release-4.17] Makefile: provide a mechanism to change the kube-rbac-proxy image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants