logrotate: add logrotate functionality for csi #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
parth-gr
force-pushed
the
logrotate-feature
branch
2 times, most recently
from
8fa90b4 to
10e384a
Compare
nb-ohad
requested changes
Jul 23, 2024
parth-gr
force-pushed
the
logrotate-feature
branch
7 times, most recently
from
20a6a92 to
c5892cb
Compare
parth-gr
force-pushed
the
logrotate-feature
branch
3 times, most recently
from
221e980 to
ca82c65
Compare
Madhu-1
requested changes
Jul 26, 2024
parth-gr
commented
Aug 1, 2024
parth-gr
force-pushed
the
logrotate-feature
branch
7 times, most recently
from
1c5b866 to
2c9dea5
Compare
parth-gr
force-pushed
the
logrotate-feature
branch
3 times, most recently
from
1eb909f to
0d3a5b1
Compare
parth-gr
force-pushed
the
logrotate-feature
branch
2 times, most recently
from
dae6541 to
c67e20f
Compare
|
@parth-gr may i know the recent change you pushed after i approved the PR? |
parth-gr
force-pushed
the
logrotate-feature
branch
from
c67e20f to
02105d3
Compare
nb-ohad
requested changes
Aug 19, 2024
parth-gr
force-pushed
the
logrotate-feature
branch
from
02105d3 to
95bd1d5
Compare
nb-ohad
requested changes
Aug 19, 2024
parth-gr
force-pushed
the
logrotate-feature
branch
from
95bd1d5 to
7a1f44a
Compare
Madhu-1
reviewed
Aug 19, 2024
nb-ohad
reviewed
Aug 19, 2024
parth-gr
force-pushed
the
logrotate-feature
branch
2 times, most recently
from
0bb7091 to
937b089
Compare
Madhu-1
reviewed
Aug 19, 2024
Madhu-1
reviewed
Aug 19, 2024
parth-gr
force-pushed
the
logrotate-feature
branch
from
937b089 to
b8b3c32
Compare
Madhu-1
previously approved these changes
Aug 19, 2024
nb-ohad
reviewed
Aug 19, 2024
currently security context was just set by looking logrotate is enabled or not, but from this commit we will also check if the cntrlplugin has prviliged true Signed-off-by: parth-gr <partharora1010@gmail.com>
parth-gr
force-pushed
the
logrotate-feature
branch
from
b8b3c32 to
9667889
Compare
|
LGTM |
Madhu-1
approved these changes
Aug 19, 2024
nb-ohad
approved these changes
Aug 19, 2024
iamniting
pushed a commit
to iamniting/ceph-csi-operator
that referenced
this pull request
Nov 12, 2024
Syncing latest changes from upstream main for ceph-csi-operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Make main container and csi addons container
log to a file(dependency on klog)
Add a log-rotate sidecar container,
so it can rotate the logs
Added other volume and volumemounts as needed
Added the privileged option for controllerplugin
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.