rebase: bump k8s.io dependencies to v0.26.7 #4053
Conversation
|
@Madhu-1 PTAL. |
|
@karthik-us can you please update the description about reason for this change |
go.mod
Outdated
| k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.26.1 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.26.1 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.26.7 | ||
| k8s.io/apiserver => k8s.io/apiserver v0.26.1 | ||
| k8s.io/cli-runtime => k8s.io/cli-runtime v0.26.1 |
There was a problem hiding this comment.
Is there a reason to not update all k8s.io packages at once?
There was a problem hiding this comment.
Yes we can change it as well 👍🏻 as the bug is in the client-go package it's only updated and not sure if updating other dependencies might cause some other regression. @nixpanic whats your suggestion?
There was a problem hiding this comment.
I guess it is recommended to update to the latest versions when possible. That will include bugfixes and so on. Mixing different versions is mst likely less well tested than using the same version for everything. In case we hit an unidentified regression, we can always downgrade again. I hope that the projects we use have good CI, and regressions are kept to a minimum.
Bumping the k8s.io dependencies to v0.26.7. The main intention is to update the client-go library dependency for kube 1.27+, where aggregated discovery is enabled. With client-go lower than v0.26.4 in some cases it is possible that the discovery response comes with the malformed response with nil GVK leading to Crash Loop Back Off state. Upstream kubernetes issue: kubernetes/kubernetes#116603 Signed-off-by: karthik-us <ksubrahm@redhat.com>
karthik-us
force-pushed
the
bump-client-go-v3.8
branch
from
f0baca0
to
68bf88a
Compare
karthik-us
changed the title
Done. |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 71925d5 |
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
Bumping the k8s.io dependencies to v0.26.7. The main intention
is to update the client-go library dependency for kube 1.27+,
where aggregated discovery is enabled. With client-go lower than
v0.26.4 in some cases it is possible that the discovery response
comes with the malformed response with nil GVK leading to Crash
Loop Back Off state.
Upstream kubernetes issue:
kubernetes/kubernetes#116603