Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy: update CSI sidecars to latest versions available #4660

Merged
merged 5 commits into from
Jun 13, 2024
Merged

deploy: update CSI sidecars to latest versions available #4660

merged 5 commits into from
Jun 13, 2024

Conversation

iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Jun 5, 2024 •
edited
Loading

Describe what this PR does

Below sidecars are updated with latest available versions

csi-node-driver-registrar: v2.10.1
csi-resizer: v1.11.1
csi-provisioner: v5.0.1
csi-attacher: v4.6.1
csi-snapshotter: v8.0.1

Closes: #4632

Is there anything that requires special attention?

Feature gate Topology is now enabled by default and will be removed in a future release. change log.
Now, its CSI driver's responsibility to report VOLUME_ACCESSIBILITY_CONSTRAINTS if it support Topology. When the CSI driver reports it external provisioner will enables it, else disables it.

This PR has changes that remove --feature-gate=Topology from RBD templates and RBD driver reports VOLUME_ACCESSIBILITY_CONSTRAINTS. Whereas, CephFS driver will not report VOLUME_ACCESSIBILITY_CONSTRAINTS since Topology is not yet supported.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar iPraveenParihar self-assigned this Jun 5, 2024
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jun 5, 2024

@iPraveenParihar rebase this PR?

@iPraveenParihar
Copy link
Contributor Author

@iPraveenParihar rebase this PR?

yea, once this is merged #4658.

@iPraveenParihar iPraveenParihar marked this pull request as ready for review June 5, 2024 09:57
@iPraveenParihar
Copy link
Contributor Author

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 5, 2024

rebase

✅ Branch has been successfully rebased

@iPraveenParihar iPraveenParihar force-pushed the update-csi-sidecars-to-latest branch from f450401 to 7e3d20b Compare June 5, 2024 09:58
Rakshith-R
Rakshith-R previously approved these changes Jun 5, 2024
View reviewed changes
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.30

Madhu-1
Madhu-1 previously approved these changes Jun 5, 2024
View reviewed changes
@iPraveenParihar
Copy link
Contributor Author

failed at


Trying to pull registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.0...

Error: initializing source docker://registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.0: reading manifest v2.11.0 in registry.k8s.io/sig-storage/csi-node-driver-registrar: manifest unknown: Failed to fetch "v2.11.0"

kubernetes-csi/node-driver-registrar#415

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jun 5, 2024

failed at


Trying to pull registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.0...

Error: initializing source docker://registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.0: reading manifest v2.11.0 in registry.k8s.io/sig-storage/csi-node-driver-registrar: manifest unknown: Failed to fetch "v2.11.0"

kubernetes-csi/node-driver-registrar#415

@iPraveenParihar lets update other except this one.

@iPraveenParihar iPraveenParihar force-pushed the update-csi-sidecars-to-latest branch from 7e3d20b to 44930f5 Compare June 5, 2024 10:58
@iPraveenParihar
Copy link
Contributor Author

@iPraveenParihar lets update other except this one.

using last working tag: v2.10.1

@mergify mergify bot dismissed stale reviews from Rakshith-R and Madhu-1 June 5, 2024 10:58

Pull request has been modified.

@iPraveenParihar iPraveenParihar force-pushed the update-csi-sidecars-to-latest branch from 44930f5 to 9aef018 Compare June 5, 2024 11:07
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.30

Madhu-1
Madhu-1 previously approved these changes Jun 6, 2024
View reviewed changes
@Madhu-1 Madhu-1 requested review from a team and Rakshith-R June 6, 2024 07:02
yati1998
yati1998 previously approved these changes Jun 6, 2024
View reviewed changes
@iPraveenParihar
Copy link
Contributor Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 6, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@iPraveenParihar iPraveenParihar force-pushed the update-csi-sidecars-to-latest branch from 9aef018 to f3f7a15 Compare June 6, 2024 07:11
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jun 6, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@iPraveenParihar @nixpanic
e2e: remove enableTopologyInTemplate method
39b35e4 
This commit removes `enableTopologyInTemplate` method as this is not
needed anymore.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 12, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the update-csi-sidecars-to-latest branch from 412b0c4 to 39b35e4 Compare June 12, 2024 14:50
@nixpanic nixpanic requested a review from a team June 12, 2024 14:58
@iPraveenParihar
Copy link
Contributor Author

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

rebase

✅ Nothing to do for rebase action

@iPraveenParihar
Copy link
Contributor Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 202f43c

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jun 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 13, 2024
@mergify mergify bot merged commit 202f43c into ceph:devel Jun 13, 2024
38 checks passed
@iPraveenParihar iPraveenParihar mentioned this pull request Jun 18, 2024
Closed
@iPraveenParihar iPraveenParihar mentioned this pull request Jul 17, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

@yati1998 yati1998 Awaiting requested review from yati1998

Assignees

@iPraveenParihar iPraveenParihar

Labels
ci/skip/multi-arch-build skip building on multiple architectures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all the kubernetes sidecar to latest release
6 participants
@iPraveenParihar @Madhu-1 @ceph-csi-bot @nixpanic @yati1998 @Rakshith-R