Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove unneeded updateSnapshotDetails() function #4840

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

cleanup: remove unneeded updateSnapshotDetails() function #4840

wants to merge 2 commits into from
+15 −54

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Sep 16, 2024 •
edited
Loading

updateSnapshotDetails() just calls getImageInfo() on an rbdVolume
created from the rbdSnapshot. getImageInfo() is a function of the
base rbdImage struct, so there really is no need for this indirection.

@nixpanic nixpanic added the component/rbd Issues related to RBD label Sep 16, 2024
@mergify mergify bot added the cleanup label Sep 16, 2024
Rakshith-R
Rakshith-R previously approved these changes Sep 17, 2024
View reviewed changes
@nixpanic
Copy link
Member Author

@Mergifyio queue

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Sep 17, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 17, 2024
@nixpanic
Copy link
Member Author

Something isn't right here... Maybe the ImageID of the snapshot/parent should not get updated?

@nixpanic nixpanic marked this pull request as draft September 17, 2024 08:56
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 17, 2024
@nixpanic
cleanup: remove unneeded updateSnapshotDetails() function
9b0383c 
`updateSnapshotDetails()` just calls `getImageInfo()` on an `rbdVolume`
created from the `rbdSnapshot`. `getImageInfo()` is a function of the
base `rbdImage` struct, so there really is no need for this indirection.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify mergify bot dismissed stale reviews from Rakshith-R and iPraveenParihar November 1, 2024 16:12

Pull request has been modified.

@nixpanic
cleanup: drop rbdVol.storeImageID() in favor of rbdVol.repairImageID()
ddd41d3 
Both `rbdVolume.repairImageID()` and `rbdVolume.storeImageID()` do the
same thing. `repairImageID()` includes optional extra checking for an
already set ImageID, which is not part of `storeImageID()`.

Remove some unneeded `ImageID == ""` checking because `repairImageID()`
does that, and remove the `storeImageID()` function.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@github-actions github-actions bot removed the stale label Nov 1, 2024
@nixpanic
Copy link
Member Author

/test ci/centos/mini-e2e/k8s-1.30

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

queue

🟠 Waiting for conditions to match

  • -draft [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R left review comments

@iPraveenParihar iPraveenParihar iPraveenParihar left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
cleanup component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nixpanic @ceph-csi-bot @iPraveenParihar @Rakshith-R