Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebase: bump google.golang.org/grpc from 1.67.1 to 1.68.0 #4952

Merged
merged 1 commit into from
Nov 14, 2024
Merged

rebase: bump google.golang.org/grpc from 1.67.1 to 1.68.0 #4952

merged 1 commit into from
Nov 14, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2024

Bumps google.golang.org/grpc from 1.67.1 to 1.68.0.

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.68.0

Behavior Changes

  • stats/opentelemetry/csm: Get mesh_id local label from "CSM_MESH_ID" environment variable, rather than parsing from bootstrap file (#7740)
  • orca (experimental): if using an ORCA listener, it must now be registered only on a READY SubConn, and the listener will automatically be stopped when the connection is lost. (#7663)
  • client: ClientConn.Close() now closes transports simultaneously and waits for transports to be closed before returning. (#7666)
  • credentials: TLS credentials created via NewTLS that use tls.Config.GetConfigForClient will now have CipherSuites, supported TLS versions and ALPN configured automatically. These were previously only set for configs not using the GetConfigForClient option. (#7709)

Bug Fixes

  • transport: prevent deadlock in client transport shutdown when writing the GOAWAY frame hangs. (#7662)
  • mem: reuse buffers more accurately by using slice capacity instead of length (#7702)
  • status: Fix regression caused by #6919 in status.Details() causing it to return a wrapped type when getting proto messages generated with protoc-gen-go < v1. (#7724)

Dependencies

  • Bump minimum supported Go version to go1.22.7. (#7624)
Commits
  • acba4d3 Change version to 1.68.0 (#7743)
  • 5363dca credentials: Apply defaults to TLS configs provided through GetConfigForClien...
  • 056dc64 status: Fix status incompatibility introduced by #6919 and move non-regenerat...
  • b79fb61 mem: use slice capacity instead of length, to determine whether to pool buffe...
  • 54841ef stats/opentelemetry/csm: Get mesh_id local label from "CSM_MESH_ID" environme...
  • ad81c20 pickfirstleaf: minor simplification to reconcileSubConnsLocked method (#7731)
  • b850ea5 transport : wait for goroutines to exit before transport closes (#7666)
  • 00b9e14 pickfirst: New pick first policy for dualstack (#7498)
  • 18a4eac testutils: add couple of log statements to the restartable listener type (#7716)
  • fdc2ec2 xdsclient: deflake TestADS_ResourcesAreRequestedAfterStreamRestart (#7720)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the rebase update the version of an external component label Nov 11, 2024
@iPraveenParihar iPraveenParihar force-pushed the dependabot/go_modules/google.golang.org/grpc-1.68.0 branch from 6ca8df6 to 3475943 Compare November 12, 2024 05:01
@iPraveenParihar
Copy link
Contributor

mod check failed -

go: updates to go.mod needed, disabled by -mod=readonly; to update it:
	go mod tidy
make: *** [Makefile:114: mod-check] Error 1
make: *** [Makefile:219: containerized-test] Error 2

go mod tidy updated go version from 1.22.5 to 1.22.7

@iPraveenParihar
Copy link
Contributor

mod check failed -

go: updates to go.mod needed, disabled by -mod=readonly; to update it:
	go mod tidy
make: *** [Makefile:114: mod-check] Error 1
make: *** [Makefile:219: containerized-test] Error 2

go mod tidy updated go version from 1.22.5 to 1.22.7

@Madhu-1, updating go version should be fine now?

nixpanic
nixpanic reviewed Nov 12, 2024
View reviewed changes
go.mod Outdated
go 1.22.5
go 1.22.7

toolchain go1.22.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the toolchain addition required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was added by go mod tidy removed it now.

@iPraveenParihar iPraveenParihar force-pushed the dependabot/go_modules/google.golang.org/grpc-1.68.0 branch from 3475943 to ebd21e3 Compare November 13, 2024 08:26
@dependabot @iPraveenParihar
rebase: bump google.golang.org/grpc from 1.67.1 to 1.68.0
3419b4f 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.67.1 to 1.68.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.67.1...v1.68.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
@iPraveenParihar iPraveenParihar force-pushed the dependabot/go_modules/google.golang.org/grpc-1.68.0 branch from ebd21e3 to 3419b4f Compare November 13, 2024 08:34
@iPraveenParihar
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 13, 2024
@iPraveenParihar
Copy link
Contributor

/retest ci/centos/mini-e2e/k8s-1.30

@mergify mergify bot merged commit d651011 into devel Nov 14, 2024
38 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/google.golang.org/grpc-1.68.0 branch November 14, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
rebase update the version of an external component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iPraveenParihar @ceph-csi-bot @nixpanic