rbd: Use assume_storage_prezeroed when formatting #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing lazy_itable_init=1 and lazy_journal_init=1 to mkfs.ext4, pass assume_storage_prezeroed=1 which is stronger and allows the filesystem to skip inode table zeroing completely instead of simply doing it lazily. Closes: ceph#4948 Signed-off-by: Niraj Yadav <niryadav@redhat.com>
nixpanic
reviewed
Dec 9, 2024
| @@ -101,7 +101,7 @@ var ( | |||
| xfsHasReflink = xfsReflinkUnset | |||
|
|
|||
| mkfsDefaultArgs = map[string][]string{ | |||
| "ext4": {"-m0", "-Enodiscard,lazy_itable_init=1,lazy_journal_init=1"}, | |||
| "ext4": {"-m0", "-Enodiscard,assume_storage_prezeroed=1"}, | |||
There was a problem hiding this comment.
make sure that you only do this when mkfs.ext4 supports the option, you'll need to add some form of detection, ideally with something like sync.Once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Instead of passing
lazy_itable_init=1andlazy_journal_init=1tomkfs.ext4,pass
assume_storage_prezeroed=1which is stronger and allows the filesystemto skip inode table zeroing completely instead of simply doing it lazily.
Closes: #4948