Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: address linting issues (backport #328) #330

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 25, 2025

This commit addresses all ansible-lint issues.


This is an automatic backport of pull request #328 done by Mergify.

@mergify mergify bot added the conflicts label Feb 25, 2025
Copy link
Author

mergify bot commented Feb 25, 2025

Cherry-pick of 41352ed has failed:

On branch mergify/bp/squid/pr-328
Your branch is up to date with 'origin/squid'.

You are currently cherry-picking commit 41352ed.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cephadm-clients.yml
	modified:   cephadm-distribute-ssh-key.yml
	modified:   cephadm-purge-cluster.yml
	modified:   cephadm-set-container-insecure-registries.yml
	modified:   rocksdb-resharding.yml
	modified:   validate/insecure-registries.yml
	modified:   validate/preflight.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ceph_defaults/meta/main.yml
	both modified:   cephadm-preflight.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@guits guits force-pushed the mergify/bp/squid/pr-328 branch from 29085e6 to 6ad6600 Compare February 25, 2025 15:50
@guits guits removed the conflicts label Feb 25, 2025
@guits guits force-pushed the mergify/bp/squid/pr-328 branch from 6ad6600 to 934637a Compare February 25, 2025 15:55
This commit addresses all ansible-lint issues.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 41352ed)
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
- Upgrade Python version from 3.8 to 3.9 in GitHub Actions workflow.
- Replace direct `pip install` for ansible-lint with a `tox` environment for better dependency management.
- Add a new `linter` environment in `tox.ini` to streamline linting for Ansible playbooks.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 3961ba6)
@guits guits force-pushed the mergify/bp/squid/pr-328 branch from 934637a to 71cece1 Compare February 25, 2025 15:56
@guits guits merged commit ae9a94e into squid Feb 25, 2025
8 checks passed
@guits guits deleted the mergify/bp/squid/pr-328 branch February 25, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant