Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: Adding ListChildrenWithParams Api #1079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShravaniVangur
Copy link

@ShravaniVangur ShravaniVangur commented Feb 24, 2025

The existing ListChildren() API provides only basic information, specifically the pool and image names of a given image’s children. However, in many scenarios, additional metadata is required to fully understand the relationships between images.

This new API extends functionality by leveraging rbd_list_children3(rbd_image_t image, rbd_linked_image_spec_t *images, size_t *max_images), which enables the retrieval of comprehensive details, including:

  • Image and pool IDs
  • Image and pool names
  • Pool namespace
  • The trash status of child images

By exposing this additional metadata, the API allows for more informed decision-making when managing child images. Furthermore, modifying the existing ListChildren() API would introduce backward compatibility issues, potentially breaking existing implementations. To avoid such disruptions while still providing enhanced capabilities, this new API has been introduced as a separate function.

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

Api retrieves Image,Pool and Trash details of the existing Children.

Signed-off-by: ShravaniVangur <shravanivangur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant