-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw/admin: Add support for /info section #936
Conversation
You're probably already aware of this since you also restarted some of the builds but some of the jobs are failing with a somewhat mysterious error, possibly a failure to download go modules. I restarted it again but if it fails again I may just suggest waiting a day or more in case this is an issue on the go module proxy server side. |
5b39b66
to
780f701
Compare
May be |
11d8f66
to
04b6fd2
Compare
ea73894
to
c667110
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find on the setup script issue. I am a bit confused by the addition of launch_rgw
which is basically exactly the same as launch_radosgw
. Why not either rename launch_radosgw to launch_rgw or keep launch_ragdosgw and have the new function named launch_radosgw2 ?
That's a very good suggestion. |
c667110
to
ae55baf
Compare
Sorry for noticing things bit-by-bit, but I see that there's no Signed-off-by of yours @anoopcs9 . The co-authored bits looks good but it only has Matt's name in the sign off line. |
^ That applies to the first 2 commits only |
To be clear: I would add one for your own. I would leave any existing sign offs |
Implement support for new /info AdminOps interface, which returns a json record similar to: { "info": { "storage_backends": [ { "name":"rados", "cluster_id":"204a1415-0b03-4926-bf76-6aebd192a52d" } ] } } Co-authored-by: Anoop C S <anoopcs@cryptolab.net> Co-authored-by: Sébastien Han <seb@redhat.com> Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Co-authored-by: Anoop C S <anoopcs@cryptolab.net> Signed-off-by: Sébastien Han <seb@redhat.com> Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
ae55baf
to
862f2c3
Compare
Updated individual commit messages with Sign Offs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While my RGW knowledge is shaky everything seems OK to me particularly WRT to i-dotting and t-crossing for go-ceph processes ;-)
Checklist
//go:build ceph_preview
make api-update
to record new APIsbased on #616