Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: bump up psycopg2 #74

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

kshtsk
Copy link
Contributor

@kshtsk kshtsk commented Aug 27, 2019

Signed-off-by: Kyr Shatskyy kyrylo.shatskyy@gmail.com

@kshtsk kshtsk requested review from zmc and djgalloway August 27, 2019 19:45
@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 6, 2019

@zmc @djgalloway guys, review please?

@yuriw yuriw requested a review from tchaikov October 6, 2019 15:48
@tchaikov
Copy link
Contributor

tchaikov commented Oct 6, 2019

why? the newer the merrier?

@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 6, 2019

This current version does not work for me on openSUSE:

     command: /home/kyr/kshtsk/paddles/v/bin/python2 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-4O1gZM/psycopg2/setup.py'"'"'; __file__='"'"'/tmp/pip-install-4O1gZM/psycopg2/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base pip-egg-info
         cwd: /tmp/pip-install-4O1gZM/psycopg2/
    Complete output (14 lines):
    running egg_info
    creating pip-egg-info/psycopg2.egg-info
    writing pip-egg-info/psycopg2.egg-info/PKG-INFO
    writing top-level names to pip-egg-info/psycopg2.egg-info/top_level.txt
    writing dependency_links to pip-egg-info/psycopg2.egg-info/dependency_links.txt
    writing manifest file 'pip-egg-info/psycopg2.egg-info/SOURCES.txt'
    Error: pg_config executable not found.
    
    Please add the directory containing pg_config to the PATH
    or specify the full executable path with the option:
    
        python setup.py build_ext --pg-config /path/to/pg_config build ...
    
    or with the pg_config option in 'setup.cfg'.
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 6, 2019

The newer version does not need pg_config at all. Also even if install the devel package of postgresql where the pg_config resides, the 2.6.1 fails with error:

     command: /home/kyr/kshtsk/paddles/v/bin/python2 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-dUp6lS/psycopg2/setup.py'"'"'; __file__='"'"'/tmp/pip-install-dUp6lS/psycopg2/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base pip-egg-info
         cwd: /tmp/pip-install-dUp6lS/psycopg2/
    Complete output (7 lines):
    running egg_info
    creating pip-egg-info/psycopg2.egg-info
    writing pip-egg-info/psycopg2.egg-info/PKG-INFO
    writing top-level names to pip-egg-info/psycopg2.egg-info/top_level.txt
    writing dependency_links to pip-egg-info/psycopg2.egg-info/dependency_links.txt
    writing manifest file 'pip-egg-info/psycopg2.egg-info/SOURCES.txt'
    Error: could not determine PostgreSQL version from '10.10'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

@tchaikov
Copy link
Contributor

tchaikov commented Oct 6, 2019

i think it still needs pg_config. see http://initd.org/psycopg/docs/install.html#install-from-source

@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 6, 2019

i think it still needs pg_config. see http://initd.org/psycopg/docs/install.html#install-from-source

I can agree, but this is not required when installing not from the source code... in the newer version I guess they fixed this issue. As I said, it can not be installed even after I install the devel package with pg_config. The newer version works fine for me... Paddles is deployed and works with postgresql without problems.

@tchaikov
Copy link
Contributor

tchaikov commented Oct 6, 2019

could you update the commit message to explain why we want to bump the required psycopg2 version?

postresql: update dependency

is not accurate and is misleading.

i think a better one is something like

requirements.txt: bump up psycopg2

psycopg2 v2.6.1 does not support postresql 10
see psycopg/psycopg2#489

psycopg2 v2.6.1 does not support postresql 10
see psycopg/psycopg2#489

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
@kshtsk kshtsk force-pushed the wip-postgres-deps branch from 7dfb097 to 43a65b7 Compare October 6, 2019 16:58
@tchaikov
Copy link
Contributor

tchaikov commented Oct 6, 2019

also, any reason not using the latest stable, say, 2.8.3?

@kshtsk kshtsk changed the title postresql: update dependency bump up psycopg2 Oct 6, 2019
@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 6, 2019

also, any reason not using the latest stable, say, 2.8.3?

I took the first working version for me at that time, and it tested for more than 2 months.
So the only reason of not taking 2.8.3 is that I haven't tested it at all.

@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 6, 2019

i think a better one is something like

requirements.txt: bump up psycopg2
psycopg2 v2.6.1 does not support postresql 10
see psycopg/psycopg2#489

DONE

@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 6, 2019

@tchaikov oh... sorry, this patch is dated by 7 May, so it has been working for me for 5 months.

@tchaikov tchaikov changed the title bump up psycopg2 requirements.txt: bump up psycopg2 Oct 7, 2019
@tchaikov tchaikov merged commit d89f50c into ceph:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants