-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements.txt: bump up psycopg2 #74
Conversation
@zmc @djgalloway guys, review please? |
why? the newer the merrier? |
This current version does not work for me on openSUSE:
|
The newer version does not need pg_config at all. Also even if install the devel package of postgresql where the pg_config resides, the 2.6.1 fails with error:
|
i think it still needs |
I can agree, but this is not required when installing not from the source code... in the newer version I guess they fixed this issue. As I said, it can not be installed even after I install the devel package with pg_config. The newer version works fine for me... Paddles is deployed and works with postgresql without problems. |
could you update the commit message to explain why we want to bump the required psycopg2 version?
is not accurate and is misleading. i think a better one is something like
|
psycopg2 v2.6.1 does not support postresql 10 see psycopg/psycopg2#489 Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
7dfb097
to
43a65b7
Compare
also, any reason not using the latest stable, say, 2.8.3? |
I took the first working version for me at that time, and it tested for more than 2 months. |
DONE |
@tchaikov oh... sorry, this patch is dated by 7 May, so it has been working for me for 5 months. |
Signed-off-by: Kyr Shatskyy kyrylo.shatskyy@gmail.com