Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install/bin/stdin-killer: macOs (Darwin) compatibility #1895

Merged
merged 1 commit into from
Oct 17, 2023
Merged

install/bin/stdin-killer: macOs (Darwin) compatibility #1895

merged 1 commit into from
Oct 17, 2023

Conversation

leonid-s-usov
Copy link
Contributor

No description provided.

@leonid-s-usov
Copy link
Contributor Author

The failing check is addressed by #1894

batrick
batrick requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

teuthology/task/install/bin/stdin-killer Outdated Show resolved Hide resolved
@leonid-s-usov
install/bin/stdin-killer: macOs (Darwin) compatibility
7955b2a 
Signed-off-by: Leonid Usov <leonid.usov@ibm.com>
zmc
zmc approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leonid-s-usov
Copy link
Contributor Author

@zmc so may I merge it then?

@zmc
Copy link
Member

zmc commented Oct 17, 2023

@batrick hm, I do not have access to teuthology on readthedocs, do you mind adding me?

@batrick
Copy link
Member

batrick commented Oct 17, 2023

@batrick hm, I do not have access to teuthology on readthedocs, do you mind adding me?

I'm not sure. You may be better asking @neha-ojha

@batrick batrick merged commit 202b180 into ceph:main Oct 17, 2023
10 of 11 checks passed
@leonid-s-usov leonid-s-usov deleted the mac/main branch October 17, 2023 20:11
@zmc
Copy link
Member

zmc commented Oct 17, 2023

@batrick you're listed as an admin, but she's not: https://readthedocs.org/projects/teuthology/

@batrick
Copy link
Member

batrick commented Oct 17, 2023

@batrick you're listed as an admin, but she's not: https://readthedocs.org/projects/teuthology/

Do you have a readthedocs username? Your emails didn't work in their lookup system. Mine for example is:

https://readthedocs.org/profiles/batrick/

which I login to with via github auth.

@zmc
Copy link
Member

zmc commented Oct 17, 2023

@batrick you're listed as an admin, but she's not: https://readthedocs.org/projects/teuthology/

Do you have a readthedocs username? Your emails didn't work in their lookup system. Mine for example is:

https://readthedocs.org/profiles/batrick/

which I login to with via github auth.

Yep, same for me - I hadn't added my RH email to the profile, but I've done that just now.

@batrick
Copy link
Member

batrick commented Oct 17, 2023

@batrick you're listed as an admin, but she's not: https://readthedocs.org/projects/teuthology/

Do you have a readthedocs username? Your emails didn't work in their lookup system. Mine for example is:
https://readthedocs.org/profiles/batrick/
which I login to with via github auth.

Yep, same for me - I hadn't added my RH email to the profile, but I've done that just now.

I've invited you to both projects.

@zmc
Copy link
Member

zmc commented Oct 17, 2023

@batrick you're listed as an admin, but she's not: https://readthedocs.org/projects/teuthology/

Do you have a readthedocs username? Your emails didn't work in their lookup system. Mine for example is:
https://readthedocs.org/profiles/batrick/
which I login to with via github auth.

Yep, same for me - I hadn't added my RH email to the profile, but I've done that just now.

I've invited you to both projects.

Thanks! Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

@zmc zmc zmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonid-s-usov @zmc @batrick