Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set keepalive: false in http(s) agent to ipfs #2065

Merged
merged 1 commit into from
Feb 28, 2022
Merged

fix: set keepalive: false in http(s) agent to ipfs #2065

merged 1 commit into from
Feb 28, 2022

Conversation

smrz2001
Copy link
Contributor

No description provided.

@smrz2001 smrz2001 requested a review from oed February 28, 2022 20:15
@linear
Copy link

linear bot commented Feb 28, 2022

NET-1224 Disable `keepalive` for IPFS HTTP Agent

nodejs/node#20256

https://nodejs.org/api/http.html#http_request_reusedsocket

@smrz2001 smrz2001 removed the request for review from oed February 28, 2022 20:15
@smrz2001 smrz2001 self-assigned this Feb 28, 2022
v-stickykeys
v-stickykeys reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@v-stickykeys v-stickykeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

packages/core/src/utils.ts Show resolved Hide resolved
@v-stickykeys
Copy link
Contributor

Oh no why are the go-ipfs tests failing now?

@smrz2001
Copy link
Contributor Author

Oh no why are the go-ipfs tests failing now?

Looks like the Polkadot test again :( @ukstv mentioned that it's known to be flaky?

FAIL  src/blockchains/__tests__/polkadot.test.ts
  ● Blockchain: Polkadot › validateLink › validate proof with secp256k

v-stickykeys
v-stickykeys approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@v-stickykeys v-stickykeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

oed
oed approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@oed oed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smrz2001 smrz2001 merged commit b0b5e70 into develop Feb 28, 2022
@smrz2001 smrz2001 deleted the feature/net-1224-disable-keepalive-for-ipfs-http-agent branch February 28, 2022 21:25
@stephhuynh18 stephhuynh18 mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-stickykeys v-stickykeys v-stickykeys approved these changes

@oed oed oed approved these changes

@stbrody stbrody Awaiting requested review from stbrody

Assignees

@smrz2001 smrz2001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smrz2001 @v-stickykeys @oed