Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update demo-rest to use the new Cerbos Go SDK #34

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

SuperAayush
Copy link
Contributor

Updated the Go SDK to use the new Cerbos Go SDK

I think the current Cerbos Go SDK uses 1.20 go version and we should also change the below to match the go versions:

go 1.18

Signed-off-by: Aayush Sharma aayusharma1401@gmail.com

cc - @charithe

Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
Copy link
Contributor

@charithe charithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the Go version should be updated to 1.22 because everything up to 1.20 is EOL now. There are some compilation errors in this PR. We no longer use the Client interface and use the concrete type *cerbos.GRPCClient instead.

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@charithe charithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run go mod tidy and also please sign all your commits.

git rebase HEAD~3 --signoff

service/service.go Outdated Show resolved Hide resolved
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
@SuperAayush SuperAayush marked this pull request as ready for review March 31, 2024 15:56
service/service.go Outdated Show resolved Hide resolved
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
@charithe charithe merged commit 6d6bd8e into cerbos:main Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants