-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update demo-rest to use the new Cerbos Go SDK #34
Conversation
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the Go version should be updated to 1.22 because everything up to 1.20 is EOL now. There are some compilation errors in this PR. We no longer use the Client
interface and use the concrete type *cerbos.GRPCClient
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run go mod tidy
and also please sign all your commits.
git rebase HEAD~3 --signoff
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
Signed-off-by: Aayush Sharma <aayusharma1401@gmail.com>
Updated the Go SDK to use the new Cerbos Go SDK
I think the current Cerbos Go SDK uses
1.20
go version and we should also change the below to match the go versions:demo-rest/go.mod
Line 3 in 25244fa
Signed-off-by: Aayush Sharma aayusharma1401@gmail.com
cc - @charithe