Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 Checkpoint #233

Merged
merged 14 commits into from
Mar 20, 2023
Merged

v5 Checkpoint #233

merged 14 commits into from
Mar 20, 2023

Conversation

i-norden
Copy link
Collaborator

@i-norden i-norden commented Mar 14, 2023

This is the bulk of the functional updates. Not quite finished but getting close. Builds but still need to fix some (most) tests.

  • rename public.blocks to ipld.blocks.
  • rename mh_key to cid.
  • consolidate all sql stmts into a single place.
  • combine ipld and cid retriever structs into a single struct. Originally these were separated because we used to first fetch a cid from Postgres directly, but then fetch the corresponding IPLD block through an ipfs.BlockService abstraction (which could be applied on-top of our DB, using ipfs-ethdb, or used on-top of an IPFS p2p block exchange. We now fetch everything from the local Postgres DB for performance reasons, in one trip where possible.
  • rename node_type => removed; refactor to support.
  • Moved some packages from geth to here, because as geth moves to v5 it no longer uses them (and this is now the only place that does).
  • use ipld-eth-statedb backend for eth_call and relevant graphql endpoints.
  • refactor to use the new (proper) uncle IPLD representation (no longer need to check ordering of returned headers).

TODO:

  • Fix unit tests
  • Rebase to 1.11.4

i-norden added 11 commits March 2, 2023 17:41
…or the separation of concerns was because we used to fetch cids directly from the database but then use those to fetch iplds using an ipfs.BlockService abstraction ontop of our database (and/or a ipfs.BlockExchange). But now they are both accessed directly in the local DB. Additionally, some of the queries should be further refined/refactored/combined as we no longer need to take two trips but can retrieve cid and ipld in the same query.
@i-norden i-norden requested a review from roysc March 15, 2023 19:21
@i-norden
Copy link
Collaborator Author

This actually isn't so bad to review

Copy link
Collaborator

@roysc roysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as an incremental part of v5.

One revision - we can change the tag of the ipld-eth-db migrations container to v5.0.0 in the docker-compose.yml. It won't work until that tag is published, but it's not run on this branch anyway.

@i-norden
Copy link
Collaborator Author

Merging this, next PR will have the test fixes

@i-norden i-norden merged commit bf55668 into v5_incremental Mar 20, 2023
@github-cerc-io github-cerc-io deleted the ian/v5_dev branch October 2, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants