Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pubsub error when subscribing to signalling topic #8

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

prathamesh0
Copy link
Collaborator

@prathamesh0 prathamesh0 commented Sep 4, 2023

Part of cerc-io/watcher-ts#409

  • Handle pubsub error in webrtc-signal component start
    • We are calling pubsub.subscribe() in the start process of webrtc-signal component
    • When starting all the libp2p components, if pubsub.subscribe() call happens before the pubsub service has started, it throws an error; encountered when using gossipsub
    • Catch the corresponding error and retry after a short delay
  • Upgrade npm go-libp2p package
    • Required as one of the binaries referenced in the post-install script of current version is no longer available on IPFS
  • Use only the required muxer in the Go nodes for interop tests as JS nodes run into an error when testing for mplex muxer and both mplex and yamux are turned on the Go side

@prathamesh0 prathamesh0 changed the title [WIP] Handle pubsub error when subscribing to signalling topic Handle pubsub error when subscribing to signalling topic Sep 5, 2023
@ashwinphatak ashwinphatak merged commit 4982655 into laconic Sep 5, 2023
24 checks passed
@ashwinphatak ashwinphatak deleted the pm-handle-pubsub branch September 5, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants