Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove voucher subscription for logs from Nitro setup #119

Merged
merged 2 commits into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"useWorkspaces": true,
"version": "0.1.9"
"version": "0.1.10"
}
4 changes: 2 additions & 2 deletions packages/example-web-app/package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "@cerc-io/example-web-app",
"version": "0.1.9",
"version": "0.1.10",
"private": true,
"dependencies": {
"@cerc-io/nitro-node": "^0.1.9",
"@cerc-io/nitro-node": "^0.1.10",
"@libp2p/crypto": "^1.0.4",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
Expand Down
10 changes: 8 additions & 2 deletions packages/example-web-app/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import './App.css';
const {
ACTORS,
createPeerIdFromKey,
createPeerAndInit
createPeerAndInit,
subscribeVoucherLogs
} = utils;

declare global {
Expand All @@ -34,7 +35,7 @@ window.setupNode = async (name: string): Promise<utils.Nitro> => {
const peerIdObj = await createPeerIdFromKey(hex2Bytes(actor.privateKey));
const peer = await createPeerAndInit(process.env.REACT_APP_RELAY_MULTIADDR, {}, peerIdObj);

return utils.Nitro.setupNode(
const nitro = await utils.Nitro.setupNode(
actor.privateKey,
DEFAULT_CHAIN_URL,
actor.chainPrivateKey,
Expand All @@ -44,6 +45,11 @@ window.setupNode = async (name: string): Promise<utils.Nitro> => {
undefined,
process.env.REACT_APP_ASSET_ADDRESS
);

// Subscribe to vouchers and log them
subscribeVoucherLogs(nitro.node);

return nitro;
};

window.out = (jsonObject) => {
Expand Down
4 changes: 2 additions & 2 deletions packages/nitro-node/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cerc-io/nitro-node",
"version": "0.1.9",
"version": "0.1.10",
"main": "dist/index.js",
"license": "MIT",
"scripts": {
Expand Down Expand Up @@ -50,7 +50,7 @@
"dependencies": {
"@cerc-io/libp2p": "0.42.2-laconic-0.1.4",
"@cerc-io/nitro-protocol": "^2.0.0-alpha.4-ts-port-0.1.2",
"@cerc-io/nitro-util": "^0.1.9",
"@cerc-io/nitro-util": "^0.1.10",
"@cerc-io/peer": "^0.2.56",
"@cerc-io/ts-channel": "1.0.3-ts-nitro-0.1.1",
"@jpwilliams/waitgroup": "^2.1.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/nitro-node/src/node/node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,8 @@ export class Node {

// ReceivedVouchers returns a chan that receives a voucher every time we receive a payment voucher
receivedVouchers(): ReadChannel<Voucher> {
return this._receivedVouchers!;
// TODO: Register listeners and send voucher to each instead
return this._receivedVouchers!.readOnly();
}

// CreateVoucher creates and returns a voucher for the given channelId which increments the redeemable balance by amount.
Expand Down
2 changes: 0 additions & 2 deletions packages/nitro-node/src/utils/nitro.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export class Nitro {
metricsApi,
);

subscribeVoucherLogs(node);
return new Nitro(node, msgService, chainService, keySigner, store);
}

Expand Down Expand Up @@ -114,7 +113,6 @@ export class Nitro {
metricsApi,
);

subscribeVoucherLogs(node);
return new Nitro(node, msgService, chainService, snapSigner, store);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/nitro-util/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cerc-io/nitro-util",
"version": "0.1.9",
"version": "0.1.10",
"main": "dist/index.js",
"license": "MIT",
"scripts": {
Expand Down
6 changes: 3 additions & 3 deletions packages/server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cerc-io/server",
"version": "0.1.9",
"version": "0.1.10",
"main": "index.js",
"license": "MIT",
"private": true,
Expand Down Expand Up @@ -33,8 +33,8 @@
"chain:anvil": "hardhat --config hardhat.anvil.config.ts node"
},
"dependencies": {
"@cerc-io/nitro-node": "^0.1.9",
"@cerc-io/nitro-util": "^0.1.9",
"@cerc-io/nitro-node": "^0.1.10",
"@cerc-io/nitro-util": "^0.1.10",
"assert": "^2.0.0",
"debug": "^4.3.4",
"dotenv": "^16.0.3",
Expand Down
4 changes: 3 additions & 1 deletion packages/server/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const log = debug('ts-nitro:server');
const {
createPeerIdFromKey,
createPeerAndInit,
subscribeVoucherLogs,
} = utils;

const getArgv = () => yargs.parserConfiguration({
Expand Down Expand Up @@ -145,7 +146,8 @@ const main = async () => {
asset,
);

log('Started P2PMessageService');
subscribeVoucherLogs(nitro.node);
log('Started P2PMessageService and subscribed to vouchers');

const peersToConnect: string[] = argv.counterparty ? [argv.counterparty] : [];
peersToConnect.push(...(argv.intermediaries as string[]));
Expand Down