Conversation
-> MyCareerManageView
career / activity
career / activity
-> ManageView
2 tasks
Yeonnies
approved these changes
Feb 9, 2026
Contributor
Yeonnies
left a comment
Yeonnies
left a comment
There was a problem hiding this comment.
잘봤습니다!
저번주부터 보던건데, 이제서야 마무리해서 올리네요..ㅜ
| func toActivityListEntity() -> ActivityListEntity { | ||
| return ActivityListEntity( | ||
| list: activityDetailResponses.map{ $0.toResumeEntityData() } | ||
| list: activityDetailResponses.map{ $0.toActivityEntity() } |
| let formats = [ | ||
| "yyyy.MM.dd", | ||
|
|
||
| // TODO: - 서버에서 연,월,일 주면 삭제 |
Contributor
Author
There was a problem hiding this comment.
기존에 서버에서 연,월만 주고 있어서 그 값을 대응하기 위해서 썼습니다. 서버 응답이 연,월,일 값으로 변경되었기 때문에 해당 부분 삭제했습니다
| action() | ||
| } label: { | ||
| Text("추가하기") | ||
| Text(buttonText) |
Contributor
There was a problem hiding this comment.
p3
혹시 추가하기 버튼 말고 다른 곳에서도 사용되나여?
추가하기에만 사용된다면 걍 추가하기 박아도 되지 않을까여..
Contributor
Author
There was a problem hiding this comment.
넹 수정뷰에서 수정하기 버튼으로도 써야해요ㅠㅠ
| case myExtracurricularActivityEditView | ||
| case myExtracurricularActivityWriteView | ||
| case myCareerManageView | ||
| case myCareerWriteView(mode: CareerWriteMode) |
Contributor
Author
There was a problem hiding this comment.
경력사항 추가, 수정 뷰를 재사용하기 때문에 mode로 구분하여 edit 모드일 때는 기존 값을 불러와서 수정하도록 하였습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌴 작업한 브랜치
feat/#184✅ 작업한 내용
❗️PR Point
앱잼 때 모델을 하나로 같이 써가지고 이번에 수정 API 붙이면서 model과 entity를 분리를 했고여,
경력사항 추가와 수정은 하나의 뷰에서 add인지 edit인지에 따라 기존 값을 넣어주는 것으로 처리했습니다.
📸 스크린샷
📟 관련 이슈