Refactor to allow resources to be serialized without the developer needing to understand the internal components #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplify and clarify naming for internal components
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist:
This PR primarily reworks the internal components to allow passing a resource, or and array of resources, to the serializer for serialization. This restores a functionality that previously existed in v0.9.x and earlier, but was made very difficult in v0.10.x.
To accomplish this the
ResourceFragmentis expanded to allow an optional reference to a resource instance. This allows theResourceTree(renamed fromResourceIdTree) to be constructed from fragments with or without full resources. TheResourceTreenow is responsible for loading the included resources instead of theProcessor. This allows the serializer to populate the full response (similar to v0.9 and earlier).Some differences in behavior from v0.9:
ResourceIdentitesare plucked and then resources are instantiated usingrecords_for_populateto fill in missing resources in the full set)