-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/ecad wind indices #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2022
It's a waste of ressources to build at import time the thresholds of ECAD indices.
- It's clearer now how each parameter of thresholds is built. - Made use of PercentileThreshold inheritance to improve type hinting - Improve import statements by truly importing the function/classes in the script and using builtin methods to access their name and module. This doesn't work with types as they don't have builtin __name__ in them though.
bzah
force-pushed
the
enh/ecad_wind_indices
branch
from
October 24, 2022 13:40
ec2cd8f
to
38a3415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request is related to #204
doc/source/references/release_notes.rst
.Describe the changes you made
Add ECAD wind indices.
Notes
The definition used for DDnorth in icclim is different from the one from ECAD ATBD v11[0].
It seems the ATBD wrongly assumes that DD can be below 0 degree in DDnorth but that should not be possible.
According to both chapter 3 of the ATBD [0] and ERA5 documentation [1] DD is bounded by [0, 360] degree.
DDsouth definition is unclear in the ATBD.
In icclim we assume DDsouth is (135° < DD <= 225°) and not (225° < DD <= 315°)
[0] https://knmi-ecad-assets-prd.s3.amazonaws.com/documents/atbd.pdf
[1] https://confluence.ecmwf.int/pages/viewpage.action?pageId=133262398