-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EAM-4101] Refine Search Page #221
Open
karolkos-glitch
wants to merge
36
commits into
master
Choose a base branch
from
EAM-4101
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolkos-glitch
commented
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware some things are still kind of draft here, however I would like get some feedback if I can proceed with the changes or I should drop the caching results logic and clean up and finish 100% the convertion of the code to functional components
karolkos-glitch
commented
Jan 20, 2025
purquijo
reviewed
Jan 20, 2025
DevauxJ
reviewed
Jan 20, 2025
karolkos-glitch
commented
Jan 21, 2025
67bb76f
to
4324d02
Compare
…and use it in Search.jsx
…chResults component
… SearchResult component
… to SearchResults
…or that texts. In transition it is grey
…lts more ilustrating the state of the app
…d by changing location in the browser
…earch logic - limit calls to API, prevent race conditions, make children only update states, handle making request in the top
…eaderFilters in the Search component
a394576
to
1f0e584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchHeader
, use render props patternSearchResults