feat(form): add (auto)save and local schema repo #87
+521
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrc
force-pushed
the
add-save-feature
branch
from
1d36a83
to
3f7bec0
Compare
pamfilos
requested changes
Nov 13, 2024
| @@ -73,7 +74,9 @@ const ObjectFieldTemplate = ({ | |||
| card.prop = properties[index]; | |||
| }); | |||
| } | |||
| setCards(newCards); | |||
| if (!isEqual(newCards, cards)) { | |||
There was a problem hiding this comment.
lets not change for now, since it is breaking some things
There was a problem hiding this comment.
I have reverted this change. The consequence is that now when loading an existing schema which contains an object field it will error out and you will need to refresh to get the schema loaded. Better to have it run like this for now instead of breaking the sorting and cause the issues mentioned in #88
miguelgrc
force-pushed
the
add-save-feature
branch
from
3f7bec0
to
1a817d2
Compare
miguelgrc
force-pushed
the
add-save-feature
branch
from
1a817d2
to
08a4bb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84
Related cernanalysispreservation/analysispreservation.cern.ch#2897
formuleCurrent). When reloading the page or closing and opening the browser the last state will be loaded automaticallyformuleForm_<formid>). It shows a badge when there are unsaved changeshideSchemaKey.initFormuleSchema()in a useEffect on first render anymore (you can still do it on demand or if you want to load an existing form).Note: When loading a schema which contains an object field the demo can crash, requiring a reload. This will be worked on in #88