-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema for Enhancement #30
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 96.67% 97.01% +0.33%
==========================================
Files 48 54 +6
Lines 1414 1572 +158
==========================================
+ Hits 1367 1525 +158
Misses 47 47
Continue to review full report at Codecov.
|
24efd47
to
17c77c4
Compare
|
||
from schemas.generic_parser_schema import GenericParserSchema | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
|
||
from schemas.parser_schema import ParserSchema | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
I think we can merge it since this code is not used at all. Later, we can have a painful time while solving merge conflicts. |
* Added schemas for publisher (Springer) parser * Added schemas for generic parser * Added schemas for enhancer output * Added tests * Added note about schemas in README * ref: cern-sis/issues-scoap3#65
@ErnestaP thank you for the code, I believe we are in a stage of investigating if the current setup works well on QA hence I will suggest to keep it open. |
No description provided.