This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
New: Added code viewer for the page (fixes #14) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should also probably update the readme. Will do that. |
abhijit945
suggested changes
Sep 24, 2019
| const codeViewer = getPageSource(pages, currentPage.pathname) ? | ||
| ( | ||
| <ExpansionPanel className={classes.expansionPanel}> | ||
| <ExpansionPanelSummary expandIcon={<ExpandMoreIcon/>}> |
There was a problem hiding this comment.
<Paper className={classes.expansionPanel}>
<ExpansionPanel>
<ExpansionPanelSummary expandIcon={<ExpandMoreIcon />}>
<Typography variant="button" color="secondary">
Source
</Typography>
</ExpansionPanelSummary>
<ExpansionPanelDetails>
<AceEditor
className={classes.aceEditor}
value={getPageSource(pages, currentPage.pathname)}
name="APP_CONTENT_CODE"
mode="javascript"
theme="twilight"
setOptions={{
showLineNumbers: true,
showGutter: true
}}
readOnly
/>
</ExpansionPanelDetails>
</ExpansionPanel>
</Paper>Rounded expand more icon Rounded the paper for editor
abhijit945
reviewed
Sep 24, 2019
| code: PropTypes.string.isRequired | ||
| }; | ||
|
|
||
| export default withStyles(styles, { withTheme: true })(SourceCodeViewer); |
| return ( | ||
| <Paper className={classes.expansionPanelContainer}> | ||
| <ExpansionPanel | ||
| classes={{ |
There was a problem hiding this comment.
I think this is rounded by default isnt it?
There was a problem hiding this comment.
oh yes it is, I removed it
| }); | ||
|
|
||
| function SourceCodeViewer(props) { | ||
| const { classes, code } = props; |
There was a problem hiding this comment.
You can use useStyles hook for this. It will save you a prop.
There was a problem hiding this comment.
Good tip, I updated to useStyles
abhijit945
approved these changes
Sep 24, 2019
abhijit945
changed the title
abhijit945
pushed a commit
that referenced
this pull request
Sep 24, 2019
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[] Documentation update
[] Bug fix
[x] New functionality
[] Changes an existing functionality
[] Other, please explain:
What changes did you make? (Give an overview)
Added a code viewer on the page
Fixes issue #14
Add any screenshots
On carbon-graphs - It will appear much better after issue https://github.com/cerner/carbon-graphs/issues/50 is fixed
The accordian will only exist if a the page comes with a source code.
