This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix: Added expiration date on local storage #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijit945
reviewed
Nov 7, 2019
| @@ -4,6 +4,17 @@ import constants from "./constants"; | |||
| export const retrieveReleases = gitHubURL => | |||
| new Promise((resolve, reject) => { | |||
| const repositoryName = gitHubURL.split("github.com")[1]; | |||
| const lsReleasesData = localStorage.getItem(constants.LOCAL_STORAGE.RELEASES_DATA) || ""; | |||
| const releasesData = lsReleasesData.split(";")[0]; | |||
There was a problem hiding this comment.
If the entry is not there then wont this be null? Does this not cause error say in a fresh page?
Did you try this after clearing the localStorage?
There was a problem hiding this comment.
Yes tried it after deleting the local storage manually so that it gets written again. The ||"" on line 7 will set the lsReleasesData to an empty string so there will not be any errors
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (Check any that's applicable)
Does this introduce a breaking change?
What changes did you make? (Give an overview)
Releases were retrieved even when tabs were flipped. This caused a lot of screen flickering and unnecessary calls to API to get releases. I added a expiry date of 24 hrs on the local storage item. If the releases are present in the local storage then they will be read. Otherwise the API call will be made - resulting in either 200 or 304 status depending on whether the resource has changed.
Add any screenshots