Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-table] Make Buttons in Selectable Header Cells Focusable #1867

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

cm9361
Copy link
Contributor

@cm9361 cm9361 commented Oct 30, 2023

Summary

What was changed:
The Terra Table was updated such that the selectable column header cell buttons are focusable instead of the column header cells.

Why it was changed:
The change was made to be compliant with accessibility standards.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

N/A

This PR resolves:

UXPLATFORM-9802


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-1867 October 30, 2023 01:29 Destroyed
@cm9361 cm9361 marked this pull request as ready for review October 30, 2023 02:14
Copy link
Contributor

@adoroshk adoroshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected, but I noticed that the focus outline got 1px thicker than it was before the change. I assume it is expected as it is visible on the test screenshots, so I am approving the PR, but decided to mention just to be sure it is not something we missed by accident.

@cm9361
Copy link
Contributor Author

cm9361 commented Oct 30, 2023

It works as expected, but I noticed that the focus outline got 1px thicker than it was before the change. I assume it is expected as it is visible on the test screenshots, so I am approving the PR, but decided to mention just to be sure it is not something we missed by accident.

Yes, this is the style called out by Eric for all of our focusable elements when in focus. The table cell layout was just negatively impacting the style.

@nikhitasharma nikhitasharma added ⭐ UX Reviewed UX Reviewed and approved. and removed UX Review Required labels Oct 30, 2023
@nikhitasharma nikhitasharma merged commit de5bfb9 into main Oct 30, 2023
21 checks passed
@nikhitasharma nikhitasharma deleted the UXPLATFORM-9802 branch October 30, 2023 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📦 terra-table ⭐ UX Reviewed UX Reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants