Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-data-grid] Resize handle communication fix #1878

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

cm9361
Copy link
Contributor

@cm9361 cm9361 commented Nov 7, 2023

Summary

What was changed:
The resize handle was updated so that its ARIA label was not communicated when a non-header cell is focused.

Why it was changed:
The resize handle was being communicated when a non-header cell was focused.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

N/A

This PR resolves:

UXPLATFORM-9803


Thank you for contributing to Terra.
@cerner/terra

@cm9361 cm9361 changed the title [terra-data=grid] Resize handle communication fix [terra-data-grid] Resize handle communication fix Nov 7, 2023
@cm9361 cm9361 marked this pull request as ready for review November 7, 2023 16:42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that #1851 is merged, I think these changes should be done on the table subcomponents.

@chrismichalewicz
Copy link

@cm9361 I tested this both for Functional and A11y, since the issue requires JAWS to test, with the scope strictly to just the issue you are addressing.

Tested with Edge + JAWS

Keyboard navigation:
Navigated the column headers with arrow keys,
• Resize handles only were communicated when they have focus
• Column headers when in focus communicated without mention of the resize handle
• Navigating to a non-header cell is communicated appropriately

Mouse:
• Unable to recreate the issue, selecting a non header cell does not communicate the resize handle as it previously was.
• Noticed with a mouse that the new column widths aren't communicated, but this is also occuring on the Prod doc site so is not related to this work. Will follow up outside this PR on this issue.

cc: @mjpalazzo

@github-actions github-actions bot temporarily deployed to preview-pr-1878 November 8, 2023 03:06 Destroyed
@cm9361 cm9361 merged commit 160498f into main Nov 8, 2023
@cm9361 cm9361 deleted the UXPLATFORM-9803 branch November 8, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants