[terra-table] Column Header Cells Accounce Changes when sorting with JAWS #2117
Conversation
kenk2
changed the title
| @@ -391,9 +391,15 @@ const ColumnHeaderCell = (props) => { | |||
| className={cx('header-container')} | |||
| {...hasButtonElement && { ref: columnHeaderCellRef, role: 'button' }} | |||
| tabIndex={buttonTabIndex} | |||
| aria-sort={sortIndicator} | |||
There was a problem hiding this comment.
This attribute is not fully supported by most of the screen readers. Will this really resolve an issue? What is not being covered by the hidden text?
There was a problem hiding this comment.
It was originally requested to add aria-sort to the column header so that it would read the sort order. However upon discovery that JAWS and most screen readers do not support this I have changed the approach to using aria-live instead on the sorting text.
packages/terra-table/tests/jest/__snapshots__/ColumnHeaderCell.test.jsx.snap
Outdated
Show resolved
Hide resolved
|
@kenk2 Is this for the issue we discussed this morning? I thought we agreed to assign it back to UX for guidance. |
|
|
@mjpalazzo That was a different issue than this one. I closed #2114 because that was the one related to removing the tab focus in that example. |
@kenk2 - thanks for letting me know. |
kenk2
changed the title
kenk2
changed the title
Summary
What was changed:
Adds Aria-Sort to the terra-table
Why it was changed:
So JAWS can ead the sortable table order.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10327
Thank you for contributing to Terra.
@cerner/terra