-
Notifications
You must be signed in to change notification settings - Fork 72
Fix focus management issue when updating folder tree children #2119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. I noticed some unexpected behavior with the reload example though where prior to clicking the "Reload Data" button, the expand all button would expand all items as expected, but after clicking "Reload Data" it would no longer expand the items. Individually row expand/collapse works fine. Most likely the expanded items state needs to be updated when the data is reloaded as well.
packages/terra-framework-docs/src/terra-dev-site/test/folder-tree/FolderTreeReload.test.jsx
Outdated
Show resolved
Hide resolved
I am pretty sure I got overzealous on the useCallback usage. I'll fix it. |
@sycombs - I fixed the test page issue. |
… being pulled into terra-compact-interactive-list
Summary
What was changed:
Fixed an issue where folder tree items could not receive focus after data was updated.
Why it was changed:
The change was made because consumers require the ability to update the data within the Folder Tree component. Accessibility should not be broken by this action.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10350
Thank you for contributing to Terra.
@cerner/terra