Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

D3 to v7 upgrade POC #317

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

D3 to v7 upgrade POC #317

wants to merge 6 commits into from

Conversation

adoroshk
Copy link
Contributor

Summary

This is a POC PR for d3 update to v7. The majority of changes in this PR were done while working in UXPLATFORM-8911.

What was changed:
Following changes introduced in d3 v6 and up have been addressed:

  1. The global d3.event has been removed in d3 v6. It is replaced by a local event passed as the first argument to all listeners. Corresponding changes have to be made to the files that contain d3.event and tests has been changed to accommodate that change.
  2. Switching to v6.0.0 and up causes 0.5px difference in graph axis width. The wdio screenshots and karma tests have been updated to accommodate that change.

Testing

This change was tested using:

  • WDIO
  • Karma
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:
UXPLATFORM-9647

@adoroshk adoroshk self-assigned this Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant