Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable grouping for dependabot #265

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Enable grouping for dependabot #265

merged 1 commit into from
Sep 19, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Sep 18, 2023

This PR adds grouping options for dependabot, it will make dependabot create single grouped PRs to upgrade deps.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups

see cert-manager/issuer-lib#65 & cert-manager/issuer-lib#67 for working example

@inteon
enable grouping for dependabot
51967e3 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2023
@inteon
Copy link
Member Author

inteon commented Sep 18, 2023

/retest

@inteon inteon mentioned this pull request Sep 19, 2023
Merged
erikgb
erikgb reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to group everything? I think the cert-manager dependency will control most of the "problematic" dependencies. Could it be an option to ignore k8s dependencies (including controller-runtime) in Dependabot configuration?

@erikgb
Copy link
Contributor

erikgb commented Sep 19, 2023

/lgtm

@jetstack-bot
Copy link
Contributor

@erikgb: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@inteon
Copy link
Member Author

inteon commented Sep 19, 2023

Do we really want to group everything? I think the cert-manager dependency will control most of the "problematic" dependencies. Could it be an option to ignore k8s dependencies (including controller-runtime) in Dependabot configuration?

I think it is the easiest solution right now:

  1. similarly to how I upgrade dependencies, it upgrades everything at the same time (we can add any necessary additional to this PR to make the PR pass tests)
  2. bundling all upgrades in 1 PR greatly reduces the noise from all these dependabot PRs.

I think this is a very good start & if necessary, we could split the PRs into more groups.

@erikgb
Copy link
Contributor

erikgb commented Sep 19, 2023

SGTM! 🚀 🚢

@maelvls
Copy link
Member

maelvls commented Sep 19, 2023

/approve

Thank you @erikgb for reviewing!

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@jetstack-bot jetstack-bot merged commit dc4bbdc into cert-manager:main Sep 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inteon @erikgb @jetstack-bot @maelvls