-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of priorityClassName to the helm chart #286
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: mjshariati98 <mjshariati98@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, it looks like this PR needs a rebase. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mjshariati98 I've been writing some documentation explaining why to set priorityClassName when deploying cert-manager and what the value should be. I am interested to know what priority class name you intend to use for the aws-privateca-issuer in production and why. |
The current helm chart doesn't support setting
priorityClassName
for the operator pods. By this PR, users can setpriorityClassName
as a helm value to be used by the operator.