-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: HPA syntax, allow v2 API #290
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b588e7e
to
a3f3c4d
Compare
@@ -2,5 +2,5 @@ apiVersion: v2 | |||
name: aws-privateca-issuer | |||
description: An addon for cert-manager to sign certificates using AWS PCA | |||
type: application | |||
version: v1.2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version bump is for when we want to cut a new release. Let's keep this at 1.2.5 for now
Signed-off-by: Jesús Fernández <fernandez.cuesta@gmail.com>
a3f3c4d
to
e551d5c
Compare
Good catch, I don't see namespace here either: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#crossversionobjectreference-v2-autoscaling. Please go ahead and make the change Brady requested and we will approve the PR for testing. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#335 has been merged, closing this one as duplicate |
HPA had apparently an additional field (checked v1 and v2 and none have
namespace
under scaleTargetRef.Support for HPA v2 added if supported by the target cluster.