chore: update to cert-manger 1.15 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also included are some fixes to the Makefile and python scripts to make them work on my machine including: - Adding `&& \` to the Makefile in cases where a `cd` is used - Fixing up the python to print strings in a nice way - Removing the python to clear down CRD descriptions (no longer needed) - Adding python to remove the new helm annotation that appears on the CRD - Adding some lines to the gitignore so it ignores python venv files/folders Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
cert-manager-prow
bot
added
dco-signoff: yes
|
Ah, cmctl has moved out of cm/cm. I'll add a fix for that |
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
ThatsMrTalbot
force-pushed
the
chore/cert-manger-1.15
branch
from
5185952 to
f02940e
Compare
wallrj
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Thanks for fixing things up.
I've recreated my WSL dev environment since I last ran these scripts and I discovered there a couple of python modules that I needed to install.
python3 -m venv venv
source venv/bin/activate
pip install semver pyyaml
make bundle-generate
It produced same changes as in this PR (except timestamps).
The sooner we switch this to the makefile-modules olm module, the better.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also included are some fixes to the Makefile and python scripts to make them work on my machine including:
&& \to the Makefile in cases where acdis usedSigned-off-by: Adam Talbot adam.talbot@venafi.com