Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it too late to align cert-manager annotations? #125

Open
cornfeedhobo opened this issue Dec 12, 2022 · 0 comments
Open

Is it too late to align cert-manager annotations? #125

cornfeedhobo opened this issue Dec 12, 2022 · 0 comments

Comments

@cornfeedhobo
Copy link
Contributor

cornfeedhobo commented Dec 12, 2022 •
edited
Loading

There is some drift between the main cert-manager controller annotations and the CSI driver volume attributes. Is there any desire to attempt to unify them? I'll be opening some PRs that will relate to this question.

Edit: it would also be nice to shore up the API constants before v1alpha is locked in. I'd be happy to take on writing the v1beta api around the cert-manager code, that way they all match.
inteon pushed a commit to inteon/csi-driver that referenced this issue Dec 11, 2024
@cert-manager-prow
Merge pull request cert-manager#125 from SgtCoDFish/allsigners
297c6d7 
Remove issuerRef from approver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cornfeedhobo