Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all go dependencies #14

Merged
merged 2 commits into from
May 30, 2023
Merged

Upgrade all go dependencies #14

merged 2 commits into from
May 30, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented May 26, 2023 •
edited
Loading

includes upgrading to sigs.k8s.io/controller-runtime v0.15.0 which required quite a few changes

@inteon
upgrade all go dependencies
ba7632e 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 26, 2023
maelvls
maelvls approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK, I mostly understand everything. I'll hold in case you want to address some of the nits, but feel free to merge now.

/lgtm
/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@inteon
improvements based on review feedback
2e41c93 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@jetstack-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@inteon inteon requested a review from maelvls May 26, 2023 14:35
@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@inteon
Copy link
Member Author

inteon commented May 30, 2023

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@jetstack-bot jetstack-bot merged commit 135836c into main May 30, 2023
@inteon inteon deleted the upgrade branch May 30, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelvls maelvls Awaiting requested review from maelvls

Assignees

@maelvls maelvls

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @jetstack-bot @maelvls