Cleanup issuer controller #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
inteon
force-pushed
the
cleanup_issuer_controller
branch
3 times, most recently
from
ac07a05
to
c0c5ea2
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
cleanup_issuer_controller
branch
from
c0c5ea2
to
4029d77
Compare
inteon
commented
Sep 4, 2023
inteon
commented
Sep 4, 2023
inteon
commented
Sep 4, 2023
inteon
commented
Sep 4, 2023
inteon
commented
Sep 4, 2023
inteon
commented
Sep 4, 2023
| fmt.Sprintf("Issuer is not ready yet: %s", err), | ||
| ) | ||
| r.EventRecorder.Event(issuer, corev1.EventTypeWarning, eventIssuerRetryableError, message) | ||
| return result, issuerStatusPatch, err // apply patch, requeue with backoff |
There was a problem hiding this comment.
We can now directly return the error to trigger a reconciliation, because the other path returns an error too (using reconcile.TerminalError).
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
jetstack-bot
removed
the
approved
inteon
commented
Sep 4, 2023
maelvls
reviewed
Sep 4, 2023
maelvls
reviewed
Sep 4, 2023
maelvls
reviewed
Sep 4, 2023
maelvls
reviewed
Sep 4, 2023
maelvls
reviewed
Sep 4, 2023
maelvls
reviewed
Sep 4, 2023
…nderstand Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
maelvls
reviewed
Sep 4, 2023
maelvls
reviewed
Sep 4, 2023
Co-authored-by: Maël Valais <mael@vls.dev> Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
cleanup_issuer_controller
branch
from
da154b6
to
b3d3097
Compare
|
Thanks for having addressed my comments. I think I’m good with the new changes. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make the issuer-controller logic a bit easier to read.
Additionally, this PR updates the Message in some of the Issuer conditions to match the event messages (eg. "Succeeded checking the issuer" instead of "checked").