Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a support kubernetes client QPS and Burst config #144

Closed
anannaya opened this issue Mar 29, 2022 · 2 comments · Fixed by #352
Closed

add a support kubernetes client QPS and Burst config #144

anannaya opened this issue Mar 29, 2022 · 2 comments · Fixed by #352

Comments

@anannaya
Copy link

image
We observed issue related to throttling, If we could get a option to reconfigure these parameter that would be helpful .

2022-03-29T07:38:49.737428Z	info	klog	Waited for 3.159691468s due to client-side throttling, not priority and fairness, request: GET:[https://172.20.0.1:443/apis/cert-manager.io/v1/namespaces/istio-system/certificaterequests/istio-csr-psmp8](https://172.20.0.1/apis/cert-manager.io/v1/namespaces/istio-system/certificaterequests/istio-csr-psmp8)
2022-03-29T07:38:49.737457Z	info	klog	Waited for 3.159691468s due to client-side throttling, not priority and fairness, request: GET:[https://172.20.0.1:443/apis/cert-manager.io/v1/namespaces/istio-system/certificaterequests/istio-csr-psmp8](https://172.20.0.1/apis/cert-manager.io/v1/namespaces/istio-system/certificaterequests/istio-csr-psmp8)
@nitishkrishna nitishkrishna mentioned this issue Nov 29, 2023
Closed
@abebars
Copy link

abebars commented Jul 16, 2024

Is there a blocker to implement this, I ran into this issue recently and had to scale the CSR deploy horizontally so we can avoid the client side throttling?

@wallrj wallrj mentioned this issue Jul 18, 2024
Closed
@wallrj
Copy link
Member

wallrj commented Jul 18, 2024

Discussed in #cert-manager on Slack: https://kubernetes.slack.com/archives/C4NV3DWUC/p1721239456716399

seankhliao added a commit to seankhliao/istio-csr that referenced this issue Jul 18, 2024
@seankhliao
Disable kubernetes client side rate limiting
f56f99d 
Trust that server side API Priority and Fairness is enabled on the
cluster, which will provide server side rate limiting. This allows a
single istio-csr pod to serve larger bursts of traffic, such as when a
large number of pods restart.

Fixes cert-manager#144
Fixes cert-manager#217

Signed-off-by: Sean Liao <sean@liao.dev>
@seankhliao seankhliao mentioned this issue Jul 18, 2024
Merged
wallrj pushed a commit to seankhliao/istio-csr that referenced this issue Jul 25, 2024
@seankhliao @wallrj
Disable kubernetes client side rate limiting
82f4bc3 
Trust that server side API Priority and Fairness is enabled on the
cluster, which will provide server side rate limiting. This allows a
single istio-csr pod to serve larger bursts of traffic, such as when a
large number of pods restart.

Fixes cert-manager#144
Fixes cert-manager#217

Signed-off-by: Sean Liao <sean@liao.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable kubernetes client side rate limiting seankhliao/istio-csr
3 participants
@wallrj @abebars @anannaya