-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to specify extra objects to apply along with the chart #378
feat: add ability to specify extra objects to apply along with the chart #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and testing locally it works. I used the following values.yaml:
extraObjects:
- |
apiVersion: v1
kind: ConfigMap
metadata:
name: 'some-extra-configmap'
- |
apiVersion: v1
kind: Namespace
metadata:
name: sandbox
---
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
name: selfsigned-issuer
namespace: sandbox
spec:
selfSigned: {}
---
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: root-ca
namespace: sandbox
spec:
isCA: true
commonName: root-ca
secretName: root-ca
privateKey:
algorithm: ECDSA
size: 256
issuerRef:
name: selfsigned-issuer
kind: Issuer
group: cert-manager.io
---
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
name: root-ca-issuer
namespace: sandbox
spec:
ca:
secretName: root-ca
And that correctly created all resources. I added some suggestions on rewording the doc comment but you might want to reword - I'm easy really.
What do you think?
3512102
to
71bb013
Compare
This is useful because istio-csr depends on an external issuer to function. The ability to configure that issuer when deploying is desirable. Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
71bb013
to
07a7d90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Cheers 🚀
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is useful because istio-csr depends on an external issuer to function. The ability to configure that issuer when deploying is desirable.