Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to specify extra objects to apply along with the chart #378

Merged

Conversation

ThatsMrTalbot
Copy link
Contributor

This is useful because istio-csr depends on an external issuer to function. The ability to configure that issuer when deploying is desirable.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2024
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and testing locally it works. I used the following values.yaml:

extraObjects:
  - |
    apiVersion: v1
    kind: ConfigMap
    metadata:
      name: 'some-extra-configmap'
  - |
    apiVersion: v1
    kind: Namespace
    metadata:
      name: sandbox
    ---
    apiVersion: cert-manager.io/v1
    kind: Issuer
    metadata:
      name: selfsigned-issuer
      namespace: sandbox
    spec:
      selfSigned: {}
    ---
    apiVersion: cert-manager.io/v1
    kind: Certificate
    metadata:
      name: root-ca
      namespace: sandbox
    spec:
      isCA: true
      commonName: root-ca
      secretName: root-ca
      privateKey:
        algorithm: ECDSA
        size: 256
      issuerRef:
        name: selfsigned-issuer
        kind: Issuer
        group: cert-manager.io
    ---
    apiVersion: cert-manager.io/v1
    kind: Issuer
    metadata:
      name: root-ca-issuer
      namespace: sandbox
    spec:
      ca:
        secretName: root-ca

And that correctly created all resources. I added some suggestions on rewording the doc comment but you might want to reword - I'm easy really.

What do you think?

deploy/charts/istio-csr/values.yaml Outdated Show resolved Hide resolved
deploy/charts/istio-csr/values.yaml Outdated Show resolved Hide resolved
@ThatsMrTalbot ThatsMrTalbot force-pushed the feat/extra-objects branch 2 times, most recently from 3512102 to 71bb013 Compare August 14, 2024 14:04
This is useful because istio-csr depends on an external issuer to function. The ability to configure that issuer when deploying is desirable.

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Cheers 🚀

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@cert-manager-prow cert-manager-prow bot merged commit 8049939 into cert-manager:main Aug 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants