Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate annotations #396

Merged

Conversation

SgtCoDFish
Copy link
Member

Example of this working from running an e2e test:

apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  annotations:
    custom.cert-manager.io/policy-name: istio-csr
    custom.cert-manager.io/second-annotation: some-value
  creationTimestamp: "2024-09-02T14:55:20Z"
  generation: 1
  name: istiod-dynamic
  namespace: istio-system
  resourceVersion: "779"
  uid: f157f3fd-2e9d-4d8e-900e-651920490cde
spec:
  commonName: istiod.istio-system.svc
  dnsNames:
  - istiod.istio-system.svc
  duration: 1h0m0s
  issuerRef:
    group: cert-manager.io
    kind: Issuer
    name: istio-ca
  privateKey:
    algorithm: RSA
    rotationPolicy: Always
    size: 2048
  renewBefore: 30m0s
  revisionHistoryLimit: 1
  secretName: istiod-tls
  uris:
  - spiffe://foo.bar/ns/istio-system/sa/istiod-service-account
status:
  conditions:
  - lastTransitionTime: "2024-09-02T14:55:20Z"
    message: Certificate is up to date and has not expired
    observedGeneration: 1
    reason: Ready
    status: "True"
    type: Ready
  notAfter: "2024-09-02T15:55:20Z"
  notBefore: "2024-09-02T14:55:20Z"
  renewalTime: "2024-09-02T15:25:20Z"
  revision: 1

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 2, 2024
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
@SgtCoDFish
Copy link
Member Author

/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@cert-manager-prow cert-manager-prow bot merged commit abe393d into cert-manager:main Sep 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants