Tweak roles to fix permission errors #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two issues here; first, there was a missing permission to
create events in the lease namespace, which would lead to failures like
the below:
```text
E0827 11:25:35.882363 1 event.go:359] "Server rejected event (will not retry!)" err="events is forbidden: User \"system:serviceaccount:venafi:cert-manager-istio-csr\" cannot create resource \"events\" in API
group \"\" in the namespace \"asd\"" event="&Event{ObjectMeta:{istio-csr.17ef92345b7ae172 asd 0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []},InvolvedObject:ObjectReference{Kind:Lease,Na
mespace:asd,Name:istio-csr,UID:ec187de6-fca5-4bb6-accb-ce601cefafb5,APIVersion:coordination.k8s.io/v1,ResourceVersion:245173,FieldPath:,},Reason:LeaderElection,Message:cert-manager-istio-csr-65f98db858-966lz_68e
4de58-2685-42fc-90a4-ae5ee49e2472 became leader,Source:EventSource{Component:cert-manager-istio-csr-65f98db858-966lz_68e4de58-2685-42fc-90a4-ae5ee49e2472,Host:,},FirstTimestamp:2024-08-27 11:25:35.876923762 +0000 U
TC m=+15.995353297,LastTimestamp:2024-08-27 11:25:35.876923762 +0000 UTC m=+15.995353297,Count:1,Type:Normal,EventTime:0001-01-01 00:00:00 +0000 UTC,Series:nil,Action:,Related:nil,ReportingController:cert-manager-i
stio-csr-65f98db858-966lz_68e4de58-2685-42fc-90a4-ae5ee49e2472,ReportingInstance:,}"
```
Second, the permissions for creating the dynamic istiod cert were tied
to the wrong namespace.
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
cert-manager-prow
bot
added
dco-signoff: yes
|
👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ThatsMrTalbot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues here; first, there was a missing permission to create events in the lease namespace if the lease namespace differs from
.Values.app.certmanager.namespace. That was observed with the below error:Second, the permissions for creating the dynamic istiod cert were tied to the wrong namespace.
.Values.app.certmanager.namespaceisn't always the same as.Values.app.istio.namespace.