Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various e2e setup tweaks #430

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

SgtCoDFish
Copy link
Member

Most importantly, adds a command for printing the latest istio version.

The istio install script we use for downloading istioctl ignores pre-releases and we want to include them, so this adds a quick oneliner to fetch the latest versions and pick the newest.

This will allow us to add a periodic test which runs with the latest released version of istio, preventing us from being surprised by a breaking change upstream in the future.

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2024
@inteon
Copy link
Member

inteon commented Oct 25, 2024

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@cert-manager-prow cert-manager-prow bot merged commit 04759ca into cert-manager:main Oct 25, 2024
17 checks passed
@SgtCoDFish SgtCoDFish deleted the e2e-setup-tweaks branch October 25, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants