Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update csi-driver-spiffe tests (part of makefile-module refactor) #953

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Update csi-driver-spiffe tests (part of makefile-module refactor) #953

merged 1 commit into from
Jan 11, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Jan 9, 2024 •
edited
Loading

Once we merge this PR, the tests on cert-manager/csi-driver-spiffe#62 should start succeeding and it should be ready to be merged.

@inteon
update csi-driver-spiffe tests (part of makefile-module refactor)
476d8e3 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2024
SgtCoDFish
SgtCoDFish approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Cheers!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@jetstack-bot jetstack-bot merged commit 1ba03d9 into cert-manager:master Jan 11, 2024
6 checks passed
@jetstack-bot
Copy link
Contributor

@inteon: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-csi-driver-spiffe-presubmits.yaml using file config/jobs/cert-manager/csi-driver-spiffe/cert-manager-csi-driver-spiffe-presubmits.yaml

In response to this:

Once we merge this PR, the tests on cert-manager/csi-driver-spiffe#62 should start succeeding and it should be ready to be merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @jetstack-bot @SgtCoDFish