Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose leader election leaseDuration and renewDeadline in helm chart #388

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Expose leader election leaseDuration and renewDeadline in helm chart #388

merged 2 commits into from
Jul 18, 2024

Conversation

jabdoa2
Copy link
Contributor

@jabdoa2 jabdoa2 commented Jul 17, 2024

No description provided.

@cert-manager-prow cert-manager-prow bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Jul 17, 2024
@cert-manager-prow
Copy link
Contributor

Hi @jabdoa2. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2024
@jabdoa2 jabdoa2 force-pushed the expose_leader_election_timeouts branch from caed192 to 2d146b5 Compare July 17, 2024 09:26
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jul 17, 2024
@erikgb
Copy link
Contributor

erikgb commented Jul 17, 2024

/ok-to-test

@jabdoa2, if you want to avoid the wait to get CI runs approved on each of your PRs, you should consider becoming a member of the cert-manager org! I'll be happy to sponsor your membership, and the process is described in https://github.com/cert-manager/community/blob/main/GOVERNANCE.md#github-member. 😸

@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2024
@jabdoa2 jabdoa2 force-pushed the expose_leader_election_timeouts branch from 2d146b5 to 4069204 Compare July 17, 2024 11:33
@inteon
Copy link
Member

inteon commented Jul 17, 2024

Please run "make generate" to generate the jsonschema used by the Helm chart.

@jabdoa2
expose leader election leaseDuration and renewDeadline in helm chart
417f805 
Signed-off-by: Jan Kantert <jan-mpf@kantert.net>
@jabdoa2 jabdoa2 force-pushed the expose_leader_election_timeouts branch from 4069204 to 417f805 Compare July 17, 2024 13:56
@cert-manager-prow cert-manager-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2024
@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Jul 17, 2024

Please run "make generate" to generate the jsonschema used by the Helm chart.

Done. Thanks for the hint!

erikgb
erikgb requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these new options available to the Helm chart, @jabdoa2! I think some of your value descriptions are a bit biased, so I have proposed some more informal ones.

Can you also please rework the PR title and add a short description?

deploy/charts/trust-manager/values.yaml Outdated Show resolved Hide resolved
deploy/charts/trust-manager/values.yaml Outdated Show resolved Hide resolved
deploy/charts/trust-manager/values.yaml Outdated Show resolved Hide resolved
@SgtCoDFish
update helm value descriptions as per @erikgb
5cd694f 
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@SgtCoDFish SgtCoDFish changed the title expose leader election leaseDuration and renewDeadline in helm chart Expose leader election leaseDuration and renewDeadline in helm chart Jul 18, 2024
erikgb
erikgb approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@cert-manager-prow cert-manager-prow bot merged commit e83d4f4 into cert-manager:main Jul 18, 2024
6 checks passed
@jabdoa2 jabdoa2 deleted the expose_leader_election_timeouts branch July 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish left review comments

@erikgb erikgb erikgb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jabdoa2 @erikgb @inteon @SgtCoDFish