refactor: move default truststore passwords to API #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
cert-manager-prow
bot
added
dco-signoff: yes
SgtCoDFish
approved these changes
Jul 19, 2024
| @@ -58,10 +58,19 @@ import "github.com/cert-manager/trust-manager/pkg/apis/trust/v1alpha1" | |||
|
|
|||
| ## Constants | |||
|
|
|||
| <a name="BundleConditionSynced"></a> | |||
There was a problem hiding this comment.
I guess this anchor link is just wrong, right? Seems to be a gomarkdoc bug - this should surely be "constants" or something similar, not the name of one of the constants.
Not a blocker obviously, just interesting!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor refactoring is extracted from #378, and the motivation is to solve circular package dependency issues.
Moving the constants to the API package seems like a good option, as the default passwords used for truststores is highly user-facing.
/cc @inteon