Drying it off #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved column selection steps to an internal function. Also moved data validation as well. Stored both functions in a new file called utlities.R
Added stop command into the data validation function, to be applied to all other functions.
Simplified the creation of dat_XGB and the xgb.mod dataframe. Both functions can be found in the utilities.R file.
certara-jcraig
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
thanks for creating additional utility functions and making code more DRY - approving @certara-mtalley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up a lot of repetitive functions, and placed the helper functions into a new utilities.R file.