Stop using pkg_resources #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2023
alexzorin
requested changes
Mar 8, 2023
|
|
||
| def vector_path(*names: str) -> str: | ||
| """Path to a test vector.""" | ||
| return pkg_resources.resource_filename( | ||
| __name__, os.path.join('testdata', *names)) | ||
| file_manager = contextlib.ExitStack() |
There was a problem hiding this comment.
It would be nice to have an explanatory comment here.
For me, it was not obvious that as_file might generate temporary files on disk that need to be cleaned up.
There was a problem hiding this comment.
That's totally reasonable. I linked to the migration guide I based this code on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #157, I got errors because the new version of
setuptoolsdeprecatespkg_resources. To fix that, I used the "Attention" message at the top of https://setuptools.pypa.io/en/latest/pkg_resources.html and https://importlib-resources.readthedocs.io/en/latest/index.html. Importingtestdataas a package like this after adding__init__.pyJust Works™ for the same reasonimport test_utilworks.