Refactoring to drop deprecated usages in pyOpenSSL
& drop Python 3.7 support
#182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Caution: This PR introduces backward incompatible changes to the library. A major version of
josepy
should be issued when this PR is merged.Caution: Defensive PR on Certbot should be merged first -> certbot/certbot#9993
This PR removes the APIs deprecated by
pyopenssl
in version 24.2+.As a consequence, several changes of
josepy
public API are made:josepy.ComparableX509
is removed since the underlying wrapped object is now objects fromcryptography
API (Certificate
orCertificateSigningRequest
) and these objects support equality checks.encode_csr
,decode_csr
,encode_cert
anddecode_cert
now manipulates objects fromcryptography
APIAside these changes, the support of Python 3.7 is dropped, given this PR will require a new major version anyway.